<html>
<head><meta charset="utf-8"><title>what&#x27;s `r? @ghost` · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html">what&#x27;s `r? @ghost`</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="208775035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208775035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208775035">(Sep 02 2020 at 03:07)</a>:</h4>
<p>What does <code>r? @ghost</code> mean?</p>



<a name="208777031"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208777031" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208777031">(Sep 02 2020 at 03:58)</a>:</h4>
<p>It assigns a fake reviewer, so nobody is actually bothered for it.</p>



<a name="208800807"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208800807" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208800807">(Sep 02 2020 at 09:48)</a>:</h4>
<p>it's a hack, really, we our bot doesn't have a way of saying "dont assign anyone", but it helpfully exits early with an exception if you give it a user that it cannot actually assign^^<br>
(that's what I was told once, anyway. maybe the exception got fixed since then.)</p>



<a name="208800839"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208800839" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208800839">(Sep 02 2020 at 09:48)</a>:</h4>
<p><code>ghost</code> is the user GH transfers ownership to when the original user that created it got deleted.</p>



<a name="208800852"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208800852" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208800852">(Sep 02 2020 at 09:48)</a>:</h4>
<p>(that, too, can be very annoying as it becomes impossible to even tell the username of who created that issue/PR.)</p>



<a name="208811624"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208811624" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208811624">(Sep 02 2020 at 11:48)</a>:</h4>
<p>some prs don't need a reviewer (e.g. rollups) but if we don't assign one then there is no way to differentiate between those prs and the ones which highfive doesn't assign a reviewer by error.</p>



<a name="208814513"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208814513" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208814513">(Sep 02 2020 at 12:17)</a>:</h4>
<p>What should I do if I want the reviewer to be someone not in the rust org?</p>



<a name="208814590"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208814590" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208814590">(Sep 02 2020 at 12:18)</a>:</h4>
<p>Right now I r? them but bors crashes and doesn't even add waiting-on-review</p>



<a name="208814670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208814670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208814670">(Sep 02 2020 at 12:18)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/76235">https://github.com/rust-lang/rust/pull/76235</a></p>



<a name="208815895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208815895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208815895">(Sep 02 2020 at 12:30)</a>:</h4>
<p>Maybe use <code>@rustbot assign</code>? I’m not sure it works in PRs though</p>



<a name="208816075"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208816075" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208816075">(Sep 02 2020 at 12:31)</a>:</h4>
<p><a href="https://github.com/rust-lang/triagebot/blob/e126e0e95d9e1ffeeab0f941525a831c5857efd7/src/handlers/assign.rs#L42">Should work, actually</a></p>



<a name="208817297"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208817297" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208817297">(Sep 02 2020 at 12:43)</a>:</h4>
<p><span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span> doesn't seem to have worked</p>



<a name="208821216"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208821216" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208821216">(Sep 02 2020 at 13:14)</a>:</h4>
<p>and then you realise they don't have bors right <span aria-label="grinning" class="emoji emoji-1f600" role="img" title="grinning">:grinning:</span></p>



<a name="208821836"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208821836" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208821836">(Sep 02 2020 at 13:18)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> gave them a <code>@bors delegate</code></p>



<a name="208869573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208869573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208869573">(Sep 02 2020 at 18:47)</a>:</h4>
<p><code>r? ghost</code> also confuses highfive so it doesn't set labels <span aria-label="frown" class="emoji emoji-1f641" role="img" title="frown">:frown:</span></p>



<a name="208916489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208916489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jubilee <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208916489">(Sep 03 2020 at 03:24)</a>:</h4>
<p>does highfive set labels other than waiting-on-review?</p>



<a name="208916510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208916510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208916510">(Sep 03 2020 at 03:25)</a>:</h4>
<p>bors will set S-waiting-on-bors when you approve and S-waiting-on-author when you r-</p>



<a name="208917179"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208917179" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jubilee <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208917179">(Sep 03 2020 at 03:39)</a>:</h4>
<p>Oh,  yes, I just am noticing rust highfive and bors both do label-setting at different parts of the PR's lifecycle, and am wondering if highfive specifically adds any others.</p>



<a name="208963600"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208963600" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208963600">(Sep 03 2020 at 13:09)</a>:</h4>
<p>I don't think it does.</p>



<a name="208967879"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/what%27s%20%60r%3F%20%40ghost%60/near/208967879" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/what&#x27;s.20.60r.3F.20.40ghost.60.html#208967879">(Sep 03 2020 at 13:39)</a>:</h4>
<p>highfive just sets waiting-on-review because it only deals with reviewer-assignment</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>